I have one WCF site that I’m managing and it started leaking memory, which ended up consuming\u00a0up all server memory and stopped working.<\/p>\n
The change I made between the incident was that I\u00a0changed from using service reference to using a class called WebServcieClinet\u00a0that dynamically instantiating the web service connection.<\/p>\n
The reason why I introduced WebServiceClient is that I wanted to dynamically change the web service endpoint.<\/p>\n
What I have missed from the class that creates the web service connection was failing to\u00a0release the unmanaged\u00a0resource.<\/p>\n
Unmanaged resource in C# is such as open file, open connection, etc., which garbage collector does not know about. For this unmanaged\u00a0resource, we need to release the resource explicitly by calling Dispose () method.<\/p>\n
Ref:\u00a0http:\/\/stackoverflow.com\/questions\/3433197\/what-exactly-are-unmanaged-resources<\/a><\/p>\n 1. Calling GC.Collect after finishing using the unmanaged resource.<\/p>\n At first, I tried to go use GC.Collect, which means that I explicitly called garbage collection method to release any resource that’s not being used anymore.<\/p>\n This seems sort or work, but not perfect. And also I could find that calling GC.Collect is very costly in terms of performance.<\/p>\n 2. Use IDisposible pattern<\/p>\n All web service connections (XXXSoapClient) made by the WebServiceClient object are unmanaged resources and those are the object inherited from IDispoable for this reason.<\/p>\n So, I applied IDisposable interface in WebServiceClient.<\/p>\n When using the WebServiceClient, we can just call Dispose() instead of calling GC.Collect.<\/p>\n As the Dispose() method releases the exact resource that needs to be released, which is much efficient in terms of performance compared to calling GC.Collect, which investigate all resources that are still being used or not.<\/p>\n After applying IDisposable pattern, there wasn’t memory leak and performance should be ok.<\/p>\n 3. Further clean up<\/p>\n I haven’t tested below, but what Dispose() does in web service base class is ‘Close’ the web service connection. In this regard, the line below may be redundant from the code of WebServiceClient.<\/p>\n Ref:\u00a0http:\/\/stackoverflow.com\/questions\/538060\/proper-use-of-the-idisposable-interface\/538238#538238<\/a><\/p>\n http:\/\/stackoverflow.com\/questions\/538060\/proper-use-of-the-idisposable-interface<\/a><\/p>\n <\/p>\n","protected":false},"excerpt":{"rendered":" I have one WCF site that I’m managing and it started leaking memory, which ended up consuming\u00a0up all server memory and stopped working. The change I made between the incident was that I\u00a0changed from using service reference to using a class called WebServcieClinet\u00a0that dynamically instantiating the web service connection. The reason why I introduced WebServiceClient… Continue reading How to prevent memory leak in WCF<\/span><\/a><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[193,180],"tags":[197,198,196,194,195,181],"class_list":["post-870","post","type-post","status-publish","format-standard","hentry","category-performance","category-wcf","tag-dispose","tag-garbage-collection","tag-idisposable","tag-memory-leak","tag-performance","tag-wcf-2","entry"],"aioseo_notices":[],"_links":{"self":[{"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/posts\/870","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/comments?post=870"}],"version-history":[{"count":9,"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/posts\/870\/revisions"}],"predecessor-version":[{"id":976,"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/posts\/870\/revisions\/976"}],"wp:attachment":[{"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/media?parent=870"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/categories?post=870"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/moneystock.net\/wp_e\/wp-json\/wp\/v2\/tags?post=870"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}WebServicesClient dm = new WebServicesClient(requestData.token, Settings.Default.EndPointUrl);\r\n\r\n\/\/ do something\r\n\r\ndm = null;\r\nGC.Collect();<\/pre>\n
public class WebServicesClient : IDisposable\r\n{\r\n bool disposed;\r\n\r\npublic void Dispose()\r\n {\r\n Dispose(true);\r\n GC.SuppressFinalize(this);\r\n }\r\n\r\nprotected virtual void Dispose(bool disposing)\r\n {\r\n if (disposed)\r\n return;\r\n\r\nif (disposing)\r\n {\r\n \/\/ Free any other manage object here.\r\n }\r\n\r\n\/\/ Free any unmanaged object here.\r\n if (soapClientA != null)\r\n {\r\n soapClientA.Close();\r\n ((IDisposable) soapClientA).Dispose();\r\n soapClientA = null;\r\n }\r\n\r\nif (soapClientB != null)\r\n {\r\n soapClientB.Close();\r\n ((IDisposable) soapClientB).Dispose();\r\n soapClientBA = null;\r\n }\r\n\r\ndisposed = true;\r\n }\r\n\r\n\/\/ This is needed only when this object directly uses managed resources\r\n ~WebServiceClient()\r\n {\r\n Dispose(false);\r\n }\r\n}<\/pre>\nWebServicesClient dm = new WebServicesClient(requestData.token, Settings.Default.EndPointUrl);\r\n\r\n\/\/ do something\r\n\r\ndm.Dispose();<\/pre>\n
soapClientA.Close();<\/pre>\n